feat(dx): repo-local session skills (newtask, handoff, prlanded)#594
Conversation
Wave 3a. Establishes the .claude/skills/ convention for this repo, encoding the session rituals that are currently prose in AGENTS.md / memory: - newtask: fresh worktree off latest origin/main + npm ci + base-freshness check + route warm — kills the stale-base, cold-worktree, and reserved-port traps. - handoff: safe commit → verify:pr-local → push → PR → ledger, with the protected- branch / provider confirmations spelled out. - prlanded: post-merge content-diff verification (squash rewrites ancestry), the orphaned-late-commit check for the auto-merge race, and ledger/memory update. Markdown only — no runtime surface. Prettier-clean (.claude/ is format-checked). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThree Claude skill documents add procedures for starting isolated repository work, safely handing off a feature branch through verification and a pull request, and confirming post-merge results. ChangesRepository workflow skills
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 6❌ Failed checks (6 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7df745420b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
To use Codex here, create a Codex account and connect to github. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/handoff/SKILL.md:
- Around line 35-44: Apply one consistent provider-operation confirmation
policy: in .claude/skills/handoff/SKILL.md lines 35-44, require an explicit
stop-and-confirm before running gh pr merge --squash --auto; in
.claude/skills/prlanded/SKILL.md line 14, either add the same confirmation
before gh pr view or explicitly document that this read-only provider check is
exempt. Ensure both skills state the chosen boundary consistently.
- Around line 20-24: Update the “Inspect first” workflow in SKILL.md to inspect
staged changes before staging, using git diff --cached or git diff HEAD
alongside the existing checks. Ensure non-owned staged paths are identified and
cleared before committing, while preserving the explicit-path staging and
secret-handling rules in the subsequent step.
In @.claude/skills/prlanded/SKILL.md:
- Around line 26-28: Update the branch-cleanup guidance in the “Clean up the
branch” step to require running git worktree remove with the explicit worktree
path from a different worktree, then use git branch -D only after confirming the
content diff is empty, including squash-merged branches. Preserve the existing
warning against force deletion before verification.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 13cd5707-b401-47a4-9846-04581094375a
📒 Files selected for processing (3)
.claude/skills/handoff/SKILL.md.claude/skills/newtask/SKILL.md.claude/skills/prlanded/SKILL.md
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 3 file(s) based on 3 unresolved review comments. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 3 file(s) based on 3 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2dc26162b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Note: Step 1 is a read-only, non-mutating query exempt from the explicit-confirmation | ||
| requirement that applies to mutating provider operations (merging, closing PRs, etc.). | ||
|
|
||
| 1. **Confirm the merge:** `gh pr view <pr> --json state,mergeCommit,mergedAt` → `MERGED`. |
There was a problem hiding this comment.
When this skill runs in a normal post-merge cleanup without a separate confirmation, these lines explicitly exempt gh pr view from the repo's GitHub/GitLab confirmation boundary. The GitHub CLI manual for gh pr view says it displays pull-request information and supports JSON fields, so this is still a GitHub PR read/API interaction; require confirmation before Step 1 instead of declaring it exempt.
Useful? React with 👍 / 👎.
| and the ahead/behind from `node scripts/check-base-freshness.mjs`. If staged paths are found | ||
| that aren't part of the current session's own work (leftover from other sessions' WIP), | ||
| unstage them with `git restore --staged <path>` before proceeding. |
There was a problem hiding this comment.
When another session has intentionally staged WIP in this shared worktree, this instruction mutates their index by unstaging those paths, even though the repo workflows require preserving unrelated staged work. The handoff can avoid committing unrelated files by staging explicit paths and stopping/asking when foreign staged paths are present, without running git restore --staged on someone else's state.
Useful? React with 👍 / 👎.
1 participant
What
Wave 3a. Establishes the
.claude/skills/convention for this repo, encoding session rituals that are currently prose in AGENTS.md / memory.newtask— fresh worktree off latestorigin/main+npm ci+ base-freshness check + route warm. Kills the stale-base, cold-worktree, and reserved-port traps.handoff— safe commit →verify:pr-local→ push → PR → ledger, with protected-branch / provider confirmations spelled out.prlanded— post-merge content-diff verification (squash rewrites ancestry), the orphaned-late-commit check for the auto-merge race, and ledger/memory update.Markdown only — no runtime surface. Prettier-clean (
.claude/is format-checked).🤖 Generated with Claude Code